[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 8 14:15:08 PDT 2019


aprantl added a comment.

In D68655#1700314 <https://reviews.llvm.org/D68655#1700314>, @jasonmolenda wrote:

> Nice fix.  The real cost of computing the aranges manually is expanding all the line tables and calling GetContiguousFileAddressRanges on them.  I wonder if avoiding the full linetable expansion here is shifting that to a different place for this operation.


No, the total user CPU time reported by Instruments goes from ~7000ms -> ~3500ms, but the wall clock from ~6s -> ~5s (both ±.5s).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68655/new/

https://reviews.llvm.org/D68655





More information about the lldb-commits mailing list