[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

[Guilherme Andrade via Phabricator via lldb-commits]

guiandrade added a comment.

Thank you for looking into this, @labath

I'd like to fix that, but I'm not sure if I understand the code well enough/ it's not clear to me what the solution would look like.

> I think the only reasonable way to do that would be to change the RegisterInfo offset for BND registers to mean the gdb-remote offset

Would that involve hard-coding an extra offset at RegisterInfos_x86_64.h:28 <https://github.com/llvm/llvm-project/blob/2946cd701067404b99c39fb29dc9c74bd7193eb3/lldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h#L28> and RegisterInfos_i386.h:32 <https://github.com/llvm/llvm-project/blob/2946cd701067404b99c39fb29dc9c74bd7193eb3/lldb/source/Plugins/Process/Utility/RegisterInfos_i386.h#L32>?

> change any code which uses it for the OS context offset to do something else (the only place doing something like that should be RegisterContextLinux_x86_64.cpp)

Would that be NativeRegisterContextLinux_x86_64.cpp <https://github.com/llvm/llvm-project/blob/63e5fb76ecfed3434252868d8cf07d676f979f2f/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp>? If yes, the idea would be to somehow remove that extra factor before the `ptrace` calls?

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62931/new/

https://reviews.llvm.org/D62931