[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

Mon Oct 7 02:00:17 PDT 2019

labath added inline comments.

================
Comment at: lldb/lit/SymbolFile/Breakpad/symtab.test:20
 # CHECK: Address: symtab.out[0x00000000004000c0] (symtab.out.PT_LOAD[0]..text2 + 16)
-# CHECK: Symbol: id = {0x00000000}, range = [0x00000000004000c0-0x00000000004000d0), name="f2"
+# CHECK: Symbol: id = {0x00000000}, range = [0x00000000004000b0-0x00000000004000f2), name="___lldb_unnamed_symbol1$$symtab.out"

----------------
Could you change the address of the entry point (in `basic-elf.yaml`) to something like 0x400100 to show that the breakpad symbols resolve correctly in the case where the entry point does not get in the way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68533/new/

https://reviews.llvm.org/D68533