[Lldb-commits] [PATCH] D68071: cmake: Link lldb libraries and tools with libclang-cpp.so when CLANG_LINK_LLVM_DYLIB=ON

Tom Stellard via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 4 14:48:00 PDT 2019


tstellar added a comment.

In D68071#1695396 <https://reviews.llvm.org/D68071#1695396>, @mgorny wrote:

> Would it be bad if I said I like mine more? I'm not a fan of implicit logic, and relying on specific filenames.


No, that's fine.  I actually started to implement it the same way as your patch, but I was worried I would miss some cases, so I went with this approach.  We can drop this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68071/new/

https://reviews.llvm.org/D68071





More information about the lldb-commits mailing list