[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

Lawrence D'Anna via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 4 09:23:52 PDT 2019


lawrence_danna added a comment.

In D68188#1694276 <https://reviews.llvm.org/D68188#1694276>, @labath wrote:

> Most of your interactions seem to be about calling methods. Would it be possible to add a PythonDataObject wrapper for this (and any other frequently used python API)? I'm hoping that we could have something like...


I think this is a good idea, but there's a //lot// of places in PythonDataObjects that need to be fixed to check for exceptions and return Expected<>.     I really think it ought to be done in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68188/new/

https://reviews.llvm.org/D68188





More information about the lldb-commits mailing list