[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

[Jaroslav Sevcik via Phabricator via lldb-commits]

jarin created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Unwind plan augmentation should compute the plan row at offset x from the instruction before offset x, but currently we compute it from the instruction at offset x. Note that this behavior is a regression introduced when moving the x86 assembly inspection engine to its own file (https://github.com/llvm/llvm-project/commit/1c9858b298d79ce82c45a2954096718b39550109#diff-375a2be066db6f34bb9a71442c9b71fcL913); the original version handled this properly by copying the previous instruction out before advancing the instruction pointer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68454

Files:
  lldb/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp
  lldb/unittests/UnwindAssembly/x86/Testx86AssemblyInspectionEngine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68454.223182.patch
Type: text/x-patch
Size: 6085 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191004/91d791db/attachment-0001.bin>