[Lldb-commits] [PATCH] D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This paragraph from that bug is interesting too:

  According to the 3.11 documentation for the GENERATED source file property, it should be used to indicate "Is this source file generated as part of the build or CMake process."  Earlier documentation does not mention "CMake process".  I was originally using it because "This information is then used to exempt the file from any existence or validity checks.", otherwise CMake would complain a about the missing source file.

Unfortunately, the cmake maintainer did not circle back to answer that, so we don't know the official cmake position, but my interpretation of this paragraph is the same as that of OP (i.e., that setting this property is the right thing to do, and the fact that it does not work is a bug in ninja or its cmake generator).

That said, this clearly does not work at the moment, so removing it is the best workaround we have.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68376/new/

https://reviews.llvm.org/D68376