[Lldb-commits] [PATCH] D68282: [JSON] Use LLVM's library for decoding JSON in StructuredData

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 1 10:20:53 PDT 2019


aprantl added inline comments.


================
Comment at: lldb/source/Utility/StructuredData.cpp:48
   }
-
-  JSONParser json_parser(buffer_or_error.get()->getBuffer());
-  return_sp = ParseJSONValue(json_parser);
-  return return_sp;
+  return ParseJSON(buffer_or_error.get()->getBuffer().str());
 }
----------------
does this propagate the error into `error`?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68282/new/

https://reviews.llvm.org/D68282





More information about the lldb-commits mailing list