[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

Sun Sep 29 23:40:35 PDT 2019

labath added a comment.

In D68130#1686184 <https://reviews.llvm.org/D68130#1686184>, @vsk wrote:

> Great find. The changes in this patch makes sense to me locally, but I'm having trouble picking up on the context necessary to confidently 'lgtm'. + @JDevlieghere & @labath to get some more experienced people.

I am not very familiar with this code either, but it seems fairly safe and straightforward to me...

> I'd love to see the big switch in ParseTypeFromDWARF broken up into small, well-commented functions bit-by-bit -- when that's done, I think I'll have a much better chance at reviewing changes. If folks agree that that's a reasonable refactor, I'd be happy to send a few patches (perhaps starting with the DW_TAG_subroutine_type handling).

+100 to that. I've tried to reduce the function down a bit by splitting the dwarf parsing stuff into the separate `ParsedTypeAttributes` class, but the amount of code left is still far too much for a single function. If it's getting in the way, feel free to undo/refactor the attribute parsing code...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68130/new/

https://reviews.llvm.org/D68130