[Lldb-commits] [PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 27 16:03:47 PDT 2019


shafik added inline comments.


================
Comment at: clang/include/clang/AST/ExternalASTMerger.h:92
   ImporterTarget Target;
+  std::shared_ptr<ASTImporterSharedState> SharedState;
 
----------------
Can you add a comment explaining what this is and why we need it and how it relates to the `ASTImpoter`.

It is not obvious just looking the local changes what effect adding this has.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68140/new/

https://reviews.llvm.org/D68140





More information about the lldb-commits mailing list