[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

Haibo Huang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 24 22:41:29 PDT 2019


hhb added a comment.

In D67993#1681901 <https://reviews.llvm.org/D67993#1681901>, @mgorny wrote:

> Yep, that's a change in the right direction. Have you (at least mentally) verified that it produces the correct path in all cases? I wouldn't trust the inputs being entirely correct.


So far I tested the easiest case in my Ubuntu. I'll do another round of tests on Windows and darwin before submit. But I'm afraid I don't have the right environment to test xcode case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67993/new/

https://reviews.llvm.org/D67993





More information about the lldb-commits mailing list