[Lldb-commits] [PATCH] D68005: Make dw_tag_t a llvm::dwarf::Tag

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, clayborg, shafik.
Herald added a subscriber: aprantl.
Herald added a project: LLDB.

When talking to Shafik about D67994 <https://reviews.llvm.org/D67994>, we discovered that `dw_tag_t` is a typedef for `uint16_t`. I believe it would be better to typedef it to `llvm::dwarf::Tag` instead, so we can use the full power of the DWARF utilities in LLVM without having to do the cast. With this approach, we only have to do the cast when reading the ULEB value.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D68005

Files:
  lldb/include/lldb/Core/dwarf.h
  lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h
  lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68005.221654.patch
Type: text/x-patch
Size: 4807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190925/7cb33e56/attachment.bin>