[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

Tue Sep 24 09:25:50 PDT 2019

labath added a comment.

In D67954#1680893 <https://reviews.llvm.org/D67954#1680893>, @compnerd wrote:

> Honestly, this is just setting up the register context for ARM64.  I dont think that there is much of a test for this.  I mean, I suppose you could test this by instantiating the context and trying to read it through the interface.  But, I question the value of such a test.  Whether you go with the in-process or out-of-process approach and whether you are doing DWARF of CodeView debugging this is going to be needed.  As to running the test suite - you can cross-compile and run the tests remotely.

I disagree. As D67892 <https://reviews.llvm.org/D67892> shows, it quite possible to mess up even with a "trivial" class as this one. Ideally I'd like to see here tests similar to what @mgorny added for x86 (see `lldb/lit/Register`). However, the problem is that we don't have a way to run those tests at the moment. Since this is a problem that's going to show up sooner or later, perhaps with more "nontrivial" patches, I think it's good to figure out what to do early.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67954/new/

https://reviews.llvm.org/D67954