[Lldb-commits] [PATCH] D67942: Install python dll to bin

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Looking at the history <https://reviews.llvm.org/D67942>  goes provide us with some clues. It seems it was done to ensure that during development launching lldb uses the same python dll that the lldb was built with. However, this was done in the days when one had to build a custom python2 interpreter to build lldb on windows, and so version mismatches were much more likely. So, it's possible this is no longer needed (though I expect there will be at least one user somewhere which has grown a dependency on this somehow).

Anyway, I don't really have a horse in this race, but my instinct would be to say that lldb should not attempt to install python anywhere (just as we don't do that on non-windows platforms). There _might_ be a case for copying it to the build dir, if it increases developer comfort substantially, but ideally, I'd try to get rid of that too...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67942/new/

https://reviews.llvm.org/D67942