[Lldb-commits] [PATCH] D67942: Install python dll to bin

Haibo Huang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 24 00:04:11 PDT 2019


hhb marked an inline comment as done.
hhb added a comment.

Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above.



================
Comment at: lldb/CMakeLists.txt:233
             COMMENT "Copying Python DLL to LLDB binaries directory.")
+        get_filename_component(PYTHON_DLL_NAME ${PYTHON_DLL} NAME)
+        install(FILES ${LLDB_BIN_DIR}/${PYTHON_DLL_NAME} DESTINATION bin)
----------------
Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67942/new/

https://reviews.llvm.org/D67942





More information about the lldb-commits mailing list