[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 23 05:12:50 PDT 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks much better to me, but maybe you could add some unit tests for the use cases this fixes (I guess that's the use case of creating a `File` object with an fd, and the writing(?) to it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67792/new/

https://reviews.llvm.org/D67792





More information about the lldb-commits mailing list