[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

Mirko Brkusanin via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 18 08:25:20 PDT 2019


mbrkusanin added a comment.

In D66795#1650305 <https://reviews.llvm.org/D66795#1650305>, @atanasyan wrote:

> But take a look at `LLVMCreateDisasmCPUFeatures` function from `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this function, we will have to change "LLVM-C" interface `LLVMCreateDisasmCPUFeatures` function.


As far as I can tell there is currently no way to specify ABI from C interface. So I just made empty `MCTargetOptions`. Same with other cases where it was needed. Some places like `llvm-mca.cpp` had required options available so there we could initialize `MCTargetOptions`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795





More information about the lldb-commits mailing list