[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

Martin Storsjö via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Sep 20 13:25:55 PDT 2019


mstorsjo added a comment.

In D67856#1677356 <https://reviews.llvm.org/D67856#1677356>, @davide wrote:

> If this doesn't break clang and gcc, fine.


FWIW, it was with clang that I ran into it, haven't tested building lldb with gcc.

But the issue can be tested with a snippet like this:

  class Foo {
  public: 
          Foo::Foo() {}
  };

With MSVC, this passes fine without any warnings. With clang-cl (or plain clang with an msvc target), it builds but warns (`-Wmicrosoft-extra-qualification`), with gcc it's an error (that can be waived with `-fpermissive`), and with clang a non-msvc target, it's an unrecoverable error.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67856/new/

https://reviews.llvm.org/D67856





More information about the lldb-commits mailing list