[Lldb-commits] [PATCH] D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC]

[Gabor Marton via Phabricator via lldb-commits]

martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

Looks good to me, thanks!



================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:324
+
+    NamedDecl *to_named_decl = dyn_cast<NamedDecl>(to);
+    // Check if we already deported this type.
----------------
teemperor wrote:
> martong wrote:
> > Would it make sense to filter out those TagDecls which are already completed?
> > E.g.:
> > ```
> > if (TagDecl *to_tag_decl = dyn_cast<TagDecl>(to))
> >   if (to_tag_decl->isCompleteDefinition()) // skip tags which are already completed
> >     return;
> > ```
> > Or this would not work because there are cases when the tag is completed, but the members are still missing? If that is the case could you please document that here too?
> Maybe, but that could make this patch non-NFC :) I can make this as a follow-up.
Okay.


================
Comment at: lldb/source/Symbol/ClangASTImporter.cpp:328
+    RecordDecl *from_record_decl = dyn_cast<RecordDecl>(from);
+    // We don't need to completed injected class name decls.
+    if (from_record_decl && from_record_decl->isInjectedClassName())
----------------
typo: "to completed" -> "to complete"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61478/new/

https://reviews.llvm.org/D61478