[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions and modules

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 220439.
teemperor retitled this revision from "[lldb] Print better diagnostics for user expressions." to "[lldb] Print better diagnostics for user expressions and modules".
teemperor added a comment.
Herald added a subscriber: usaxena95.

- Rebased test.
- Also testing Objective-C modules now (as the ClangModulesDeclVendor provides valid SourceLocations, so this patch also improves diagnostics from modules).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65646/new/

https://reviews.llvm.org/D65646

Files:
  clang/include/clang/Basic/DiagnosticOptions.def
  clang/lib/Frontend/TextDiagnostic.cpp
  lldb/packages/Python/lldbsuite/test/commands/expression/diagnostics/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/diagnostics/TestExprDiagnostics.py
  lldb/packages/Python/lldbsuite/test/commands/expression/diagnostics/main.cpp
  lldb/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods.py
  lldb/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65646.220439.patch
Type: text/x-patch
Size: 27196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190917/0b0b6256/attachment-0001.bin>