[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 12 15:08:07 PDT 2019


jingham added a comment.

It seems weird to me to have the GDBRemotePacket class live in the repro namespace.  There's nothing particularly Reproducer specific about it, and it clearly gets used outside the reproducer as well.  Wouldn't it make more sense to have this in Utils?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67523/new/

https://reviews.llvm.org/D67523





More information about the lldb-commits mailing list