[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks great now. Thank you for your patience. Just make sure to deal with the breakages from the other patch first. If the fix is non trivial, or if it's going to take a while, then please revert to unbreak the bots.



================
Comment at: lldb/lit/Modules/ELF/minidebuginfo-corrupt-xz.yaml:1
+# REQUIRES: system-linux, lzma
+
----------------
system-linux shouldn't be required here. One of the reasons I wanted to have these tests is that they can run on any system, not just on linux.


================
Comment at: lldb/lit/Modules/ELF/minidebuginfo-find-symbols.yaml:1
+# REQUIRES: system-linux, lzma
+
----------------
No system-linux


================
Comment at: lldb/lit/Modules/ELF/minidebuginfo-no-lzma.yaml:1
+# REQUIRES: system-linux, !lzma
+
----------------
no system-linux


================
Comment at: lldb/source/Host/common/LZMA.cpp:129
+  uint64_t uncompressedSize = 0;
+  auto err = getUncompressedSize(InputBuffer, uncompressedSize);
+  if (err)
----------------
MaskRay wrote:
> if (auto err = ...)
>   return err;
I have a feeling this pattern is actually more common in lldb. I tend to use this one, but I am fine with either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66791/new/

https://reviews.llvm.org/D66791