[Lldb-commits] [PATCH] D67049: 1/2: Code cleanup: Change FormattersContainer::KeyType from SP to rvalue

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Sep 1 08:22:02 PDT 2019


jankratochvil created this revision.
jankratochvil added reviewers: labath, JDevlieghere, jingham.
jankratochvil added a project: LLDB.
Herald added a reviewer: jdoerfert.

There is now `std::shared_ptr` passed around which is expensive for manycore CPUs.
Most of the times (except for 3 cases) it is now just `std::move`d with no CPU locks needed.
It also makes it possible to sort the keys (which is now not needed much after D66398 <https://reviews.llvm.org/D66398>.
This was originally D66392 <https://reviews.llvm.org/D66392> but then that one ended up as a different patch.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D67049

Files:
  lldb/include/lldb/DataFormatters/FormattersContainer.h
  lldb/include/lldb/DataFormatters/TypeCategory.h
  lldb/include/lldb/Target/Target.h
  lldb/include/lldb/Utility/RegularExpression.h
  lldb/source/API/SBTarget.cpp
  lldb/source/API/SBTypeCategory.cpp
  lldb/source/Breakpoint/BreakpointResolverName.cpp
  lldb/source/Commands/CommandObjectBreakpoint.cpp
  lldb/source/Commands/CommandObjectType.cpp
  lldb/source/DataFormatters/FormatManager.cpp
  lldb/source/DataFormatters/FormattersHelpers.cpp
  lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
  lldb/source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67049.218263.patch
Type: text/x-patch
Size: 27687 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190901/88d7310e/attachment-0001.bin>


More information about the lldb-commits mailing list