[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 30 11:27:33 PDT 2019


stella.stamenova added a comment.

Is there a way to reduce some of the code duplication? The more duplication there is, the harder it is to maintain.



================
Comment at: cmake/modules/LLDBConfig.cmake:240
+  if (NOT DEFINED CMAKE_BUILD_TYPE)
+    # multiconfiguration generator was selected (i.e. Visual Studio)
+    # so print both debug and release variables related to python
----------------
Nit: multi-configuration


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66994/new/

https://reviews.llvm.org/D66994





More information about the lldb-commits mailing list