[Lldb-commits] [PATCH] D66966: [test] Fix various module cache bugs and inconsistencies

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/lit/CMakeLists.txt:18
 
+set(LLDB_TEST_MODULE_CACHE_LLDB "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-lldb" CACHE PATH "The module cache used by lldb for running tests.")
+set(LLDB_TEST_MODULE_CACHE_CLANG "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-clang" CACHE PATH "The module cache used by clang to build inferiors.")
----------------
`"The Clang module cache used by the Clang embedded in LLDB while running tests."`


================
Comment at: lldb/lit/CMakeLists.txt:19
+set(LLDB_TEST_MODULE_CACHE_LLDB "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-lldb" CACHE PATH "The module cache used by lldb for running tests.")
+set(LLDB_TEST_MODULE_CACHE_CLANG "${LLDB_TEST_BUILD_DIRECTORY}/module-cache-clang" CACHE PATH "The module cache used by clang to build inferiors.")
+
----------------
"The Clang module cache used by the Clang while building tests."


================
Comment at: lldb/lit/Settings/TestModuleCacheSanity.test:2
+# This is a sanity check that verifies that the module cache path is set
+# correctly and points to the default test build directory.
+RUN: %lldb -o 'settings show symbols.clang-modules-cache-path' | FileCheck  %s
----------------
points `inside` the


================
Comment at: lldb/lit/Settings/TestModuleCacheSanity.test:4
+RUN: %lldb -o 'settings show symbols.clang-modules-cache-path' | FileCheck  %s
+CHECK: lldb-test-build.noindex
----------------
CHECK: lldb-test-build.noindex{{.*}}module-cache-lldb


================
Comment at: lldb/packages/Python/lldbsuite/test/sanity/TestModuleCacheSanity.py:3
+This is a sanity check that verifies that the module cache path is set
+correctly and points to the default test build directory.
+"""
----------------
see my comment in the other test


================
Comment at: lldb/packages/Python/lldbsuite/test/sanity/TestModuleCacheSanity.py:17
+
+  # If your test case doesn't stress debug info, the
+  # set this to true.  That way it won't be run once for
----------------
delete this comment


================
Comment at: lldb/packages/Python/lldbsuite/test/sanity/TestModuleCacheSanity.py:25
+        'settings show symbols.clang-modules-cache-path',
+        substrs=['lldb-test-build.noindex'])
----------------
see my comment in the other test


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66966/new/

https://reviews.llvm.org/D66966