[Lldb-commits] [lldb] r370266 - [dotest] Remove --event-add-entries

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 28 14:31:53 PDT 2019


Author: jdevlieghere
Date: Wed Aug 28 14:31:53 2019
New Revision: 370266

URL: http://llvm.org/viewvc/llvm-project?rev=370266&view=rev
Log:
[dotest] Remove --event-add-entries

This argument was used by dosep.py to pass information around from the
workers. With dosep.py gone, I'm fairly sure we don't need this any
longer.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/dotest.py
    lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest.py?rev=370266&r1=370265&r2=370266&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest.py Wed Aug 28 14:31:53 2019
@@ -444,24 +444,6 @@ def parseOptionsAndInitTestdirs():
     if args.test_build_dir:
         configuration.test_build_dir = args.test_build_dir
 
-    if args.event_add_entries and len(args.event_add_entries) > 0:
-        entries = {}
-        # Parse out key=val pairs, separated by comma
-        for keyval in args.event_add_entries.split(","):
-            key_val_entry = keyval.split("=")
-            if len(key_val_entry) == 2:
-                (key, val) = key_val_entry
-                val_parts = val.split(':')
-                if len(val_parts) > 1:
-                    (val, val_type) = val_parts
-                    if val_type == 'int':
-                        val = int(val)
-                entries[key] = val
-        # Tell the event builder to create all events with these
-        # key/val pairs in them.
-        if len(entries) > 0:
-            EventBuilder.add_entries_to_all_events(entries)
-
     # Gather all the dirs passed on the command line.
     if len(args.args) > 0:
         configuration.testdirs = [os.path.realpath(os.path.abspath(x)) for x in args.args]

Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py?rev=370266&r1=370265&r2=370266&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py Wed Aug 28 14:31:53 2019
@@ -243,13 +243,6 @@ def create_parser():
         help=('Specify an option to pass to the formatter. '
               'Use --results-formatter-option="--option1=val1" '
               'syntax.  Note the "=" is critical, don\'t include whitespace.'))
-    group.add_argument(
-        '--event-add-entries',
-        action='store',
-        help=('Specify comma-separated KEY=VAL entries to add key and value '
-              'pairs to all test events generated by this test run.  VAL may '
-              'be specified as VAL:TYPE, where TYPE may be int to convert '
-              'the value to an int'))
 
     # Re-run related arguments
     group = parser.add_argument_group('Test Re-run Options')




More information about the lldb-commits mailing list