[Lldb-commits] [PATCH] D66841: Skip test_target_create_invalid_core_file on Windows

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 27 15:57:47 PDT 2019


amccarth created this revision.
amccarth added a reviewer: teemperor.

The operation is supposed to fail, but apparently it fails on Windows for a different reason than the test anticipated.


https://reviews.llvm.org/D66841

Files:
  lldb/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py


Index: lldb/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py
+++ lldb/packages/Python/lldbsuite/test/functionalities/target_command/TestTargetCommand.py
@@ -341,6 +341,7 @@
         self.expect("target create -s doesntexist doesntexisteither", error=True,
                     substrs=["invalid symbol file path 'doesntexist'"])
 
+    @skipIfWindows
     @no_debug_info_test
     def test_target_create_invalid_core_file(self):
         invalid_core_path = os.path.join(self.getSourceDir(), "invalid_core_file")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66841.217520.patch
Type: text/x-patch
Size: 707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190827/ddd18643/attachment.bin>


More information about the lldb-commits mailing list