[Lldb-commits] [lldb] r369910 - Really fix the type mismatch error in GDBRemoteCommunicationServerCommon

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 26 06:56:33 PDT 2019


Author: labath
Date: Mon Aug 26 06:56:33 2019
New Revision: 369910

URL: http://llvm.org/viewvc/llvm-project?rev=369910&view=rev
Log:
Really fix the type mismatch error in GDBRemoteCommunicationServerCommon

My previous attempt in attempt in r369904 actually broke the 32bit build
because File::Read expects to take a reference to size_t. Fix the
warning by using SIZE_MAX to denote failure instead.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp?rev=369910&r1=369909&r2=369910&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp Mon Aug 26 06:56:33 2019
@@ -550,10 +550,10 @@ GDBRemoteCommunicationServerCommon::Hand
   packet.SetFilePos(::strlen("vFile:pread:"));
   int fd = packet.GetS32(-1);
   if (packet.GetChar() == ',') {
-    uint64_t count = packet.GetU64(UINT64_MAX);
+    size_t count = packet.GetU64(SIZE_MAX);
     if (packet.GetChar() == ',') {
       off_t offset = packet.GetU64(UINT32_MAX);
-      if (count == UINT64_MAX) {
+      if (count == SIZE_MAX) {
         response.Printf("F-1:%i", EINVAL);
         return SendPacketNoLock(response.GetString());
       }




More information about the lldb-commits mailing list