[Lldb-commits] [PATCH] D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks for cleaning this up, Raphael!



================
Comment at: lldb/source/API/SBCommandInterpreter.cpp:379
+
+  // Make the result array indexed from 1 again by adding the 'common prefix'
+  // of all completions as element 0.
----------------
Maybe add that this is here to emulate old behavior that our clients rely on. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66536/new/

https://reviews.llvm.org/D66536