[Lldb-commits] [PATCH] D66447: Add char8_t support (C++20)

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This looks good to me, but why are we using a nul character to test utf8 support? Shouldn't we insert some funnier characters too? I mean, one of the advantages of unicode is that it should not be affected by the system code pages and such, so hopefully this would not cause problems even on some more exotic setups. (And I am pretty sure I remember already seeing some chinese chars in some of our data formatter tests)



================
Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/char8_t/Makefile:6
+
+clean: OBJECTS+=$(wildcard main.d.*)
+
----------------
I'm pretty sure this part isn't needed too, particularly as we now don't even run the clean actions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66447/new/

https://reviews.llvm.org/D66447