[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks fine to me. A few nits.



================
Comment at: lldb/include/lldb/Utility/RegularExpression.h:98
+  /// The compiled regular expression.
+  mutable llvm::Regex m_regex;
 };
----------------
Why does this need to be mutable?


================
Comment at: lldb/source/Commands/CommandObjectFrame.cpp:1
-//===-- CommandObjectFrame.cpp ----------------------------------*- C++ -*-===//
+//===-- CommandObrectFrame.cpp ----------------------------------*- C++ -*-===//
 //
----------------
revert


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66174/new/

https://reviews.llvm.org/D66174