[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

António Afonso via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 8 19:05:15 PDT 2019


aadsm added a comment.

I can see the appeal of having the contents next to the logic that is testing it, but I'm somewhat concerned for the cases where it includes +1000 lines of YAML in the test file. I think for those cases it might make sense to consider these fixtures and be in their own file?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65949/new/

https://reviews.llvm.org/D65949





More information about the lldb-commits mailing list