[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:318
+  if(MSVC)
+    set(flag_werror "/WX")
+  endif()
----------------
sgraenitz wrote:
> I copied the flag from LLVM. Is it the right one for MSVC?
Yes:
https://docs.microsoft.com/en-us/cpp/build/reference/compiler-option-warning-level?view=vs-2019
https://docs.microsoft.com/en-us/cpp/build/reference/wx-treat-linker-warnings-as-errors?view=vs-2019


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65939/new/

https://reviews.llvm.org/D65939