[Lldb-commits] [PATCH] D65566: [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project

Mon Aug 5 15:16:00 PDT 2019

JDevlieghere added a comment.

In D65566#1612051 <https://reviews.llvm.org/D65566#1612051>, @sgraenitz wrote:

> In D65566#1611007 <https://reviews.llvm.org/D65566#1611007>, @JDevlieghere wrote:
>
> > Is there a way to use the debugserver in the framework instead?
>
>
> This patch is about the debugserver in the framework. It must be signed, because the lldb driver uses it implicitly and, apparently, that is the correct behavior.
>  debugserver is built as `bin/debugserver` and copied to `bin/LLDB.framework/Resources/debugserver` (the latter is currently not signed in Xcode builds).

Ok, thanks, I misunderstood and thought it was the other way around.

>> This seems like the inverse of the problem we had earlier with the RPATHs, where we would fix them up in the build tree after copying them.
> 
> It's purely about the functionality of the build-tree lldb.
> 
> BTW The problem you may refer to (--> https://reviews.llvm.org/D61952#change-2C1slKxbErMH ?) is unrelated, but it's still existing when installing with the framework. Currently it doesn't show up upstream, because in practice configuration-order defines install-order. So, we are good as long as tools that go into the framework are configured after the framework.

Yep, that's the thing I had in mind.

Anyway, what I was trying to express is that this change feels ad-hoc and I'm wondering if we can tackle it more structurally.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65566/new/

https://reviews.llvm.org/D65566