[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

Haibo Huang via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 5 13:28:20 PDT 2019


hhb added inline comments.


================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55
 #define PATH_MAX MAX_PATH
+#endif
 typedef int socklen_t;
----------------
amccarth wrote:
> Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the `#define` instead of executing it conditionally.
PATH_MAX is used in SendProcessEvent (line 283)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65691/new/

https://reviews.llvm.org/D65691





More information about the lldb-commits mailing list