[Lldb-commits] [lldb] r367386 - Change '|' to '&' in conditional.

Richard Trieu via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 30 21:41:06 PDT 2019


Author: rtrieu
Date: Tue Jul 30 21:41:05 2019
New Revision: 367386

URL: http://llvm.org/viewvc/llvm-project?rev=367386&view=rev
Log:
Change '|' to '&' in conditional.

Bitwise-or with a non-zero constant will always evaluate to true.  Switch to
bitwise-and which will only evalute to true if the specified bit is set in the
other operand.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp?rev=367386&r1=367385&r2=367386&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Tue Jul 30 21:41:05 2019
@@ -735,7 +735,7 @@ SymbolFilePDB::ResolveSymbolContext(cons
       resolve_scope & eSymbolContextLineEntry) {
     auto cu_sp = GetCompileUnitContainsAddress(so_addr);
     if (!cu_sp) {
-      if (resolved_flags | eSymbolContextVariable) {
+      if (resolved_flags & eSymbolContextVariable) {
         // TODO: Resolve variables
       }
       return 0;




More information about the lldb-commits mailing list