[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Aug 4 09:24:06 PDT 2019


krytarowski added inline comments.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:104
+  // TODO: PTRACE_FORK | PTRACE_VFORK | PTRACE_POSIX_SPAWN?
+  events.pe_set_event = PTRACE_LWP_CREATE | PTRACE_LWP_EXIT;
+  status = PtraceWrapper(PT_SET_EVENT_MASK, pid, &events, sizeof(events));
----------------
I would go for more generic `PT_GET_EVENT_MASK` and then `|=`. In theory we could add more bits and make them enabled by default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65555/new/

https://reviews.llvm.org/D65555





More information about the lldb-commits mailing list