[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

Fri Aug 2 10:10:59 PDT 2019

jingham added inline comments.

================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737
+  for (auto it = m_threads.begin(); it != m_threads.end(); ++it) {
+    if (*it && ((*it)->GetID() == thread_id)) {
+      m_threads.erase(it);
----------------
mgorny wrote:
> jfb wrote:
> > mgorny wrote:
> > > labath wrote:
> > > > It looks like the rest of the code assumes (as I think it should) that the thread list does not contain null pointers. See e.g. the loop on line 276.
> > > For the record, I've copied it from Linux ;-P.
> > Are you serious? Because you absolutely cannot copy code from Linux into LLVM.
> I meant LLDB Linux Process plugin.
I believe Michal means he copied it from the Linux NativeProcess implementation in lldb to the NetBSD Process plugin in lldb.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65555/new/

https://reviews.llvm.org/D65555