[Lldb-commits] [PATCH] D65646: [lldb] Print better diagnostics for user expressions.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 2 08:50:26 PDT 2019


aprantl added a comment.

I have a question based on my half-knowledge about the expression evaluator: I thought that we already wrote out a temporary file for the expression in order to support `expr -g`? Is this orthogonal or do we now have to ways of pretending there is a source file backing up the expression?



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:73
+static const char *c_start_marker = "#line 1 \"<user expression>\"\n";
+static const char *c_end_marker = "\n;    /*LLDB_BODY_END*/\n";
 
----------------
The comment seems asymmetric now.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65646/new/

https://reviews.llvm.org/D65646





More information about the lldb-commits mailing list