[Lldb-commits] [PATCH] D64993: Fix PC adjustment in StackFrame::GetSymbolContext

Thu Aug 1 03:59:58 PDT 2019

labath added a comment.

In D64993#1608946 <https://reviews.llvm.org/D64993#1608946>, @JosephTremoulet wrote:

> In D64993#1608452 <https://reviews.llvm.org/D64993#1608452>, @labath wrote:
>
> > I haven't looked at the implementation, but I did run into the problem you are fixing in the past, and I am happy that someone is finally implementing this. I just wanted to say that for testing, I think you should be able to create some hand-written assembly that creates the kind of stack frames and unwind info you need to trigger this. You can look at existing tests in `lldb/lit/Unwind` for examples.
>
>
> Thanks for the tip!  I was indeed able to copy one of those and adapt it to test this.

Awesome. Thanks for adding the test. The test looks great.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64993/new/

https://reviews.llvm.org/D64993