[Lldb-commits] [PATCH] D65498: Fix completion for functions in anonymous namespaces

Wed Jul 31 10:54:58 PDT 2019

JDevlieghere added a comment.

In D65498#1607819 <https://reviews.llvm.org/D65498#1607819>, @teemperor wrote:

> I think it's possible to rewrite the line when doing a completion, but I remember that I got annoyed when I tried understand the code responsible for that (and decipher the magic return values). Can you file a radar maybe and I'll fix this once I got around to refactor the related code? This patch can go IMHO, so LGTM.

I think we could solve this issue by storing more information with the candidates, like a bit that says that we should clear (part) of the current line. However, currently candidates are stored in StringLists, which do not have such capabilities. The part that rewrites the line should be relatively straightforward.

I've filed rdar://53769355. I might come back to it myself as I'd like to have this non-prefix completion functionality.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65498/new/

https://reviews.llvm.org/D65498