[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

Tue Jul 30 14:23:27 PDT 2019

guiandrade added a comment.

Oh, sorry about that. I was relying on `ninja check`, which runs okay for me.

  > ninja check
  [0/1] Running the LLVM regression tests
  Testing Time: 583.96s
    Expected Passes    : 32141
    Expected Failures  : 147
    Unsupported Tests  : 438

How can I invoke those other tests? (in case it's relevant, here's my cmake command `cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS='lldb;clang;libcxx'`)

About not tying `G` and `g` together, maybe could we remove this branch <https://github.com/llvm/llvm-project/blob/63e5fb76ecfed3434252868d8cf07d676f979f2f/lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp#L336>?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62931/new/

https://reviews.llvm.org/D62931