[Lldb-commits] [lldb] r367358 - [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 30 14:22:17 PDT 2019


Author: xiaobai
Date: Tue Jul 30 14:22:17 2019
New Revision: 367358

URL: http://llvm.org/viewvc/llvm-project?rev=367358&view=rev
Log:
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module

As of svn rL367298, SymbolFileDWARF locks the module in many cases where
it needs to parse some aspect of the DWARF symbol file.
SymbolFileDWARF::ParseLineTable needs to lock the module because
SymbolVendor::ParseLineTable no longer locks it.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=367358&r1=367357&r2=367358&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Tue Jul 30 14:22:17 2019
@@ -928,7 +928,7 @@ static void ParseDWARFLineTableCallback(
 }
 
 bool SymbolFileDWARF::ParseLineTable(CompileUnit &comp_unit) {
-  ASSERT_MODULE_LOCK(this);
+  std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
   if (comp_unit.GetLineTable() != nullptr)
     return true;
 




More information about the lldb-commits mailing list