[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 30 01:39:20 PDT 2019

labath added a comment.

In D65401#1604870 <https://reviews.llvm.org/D65401#1604870>, @clayborg wrote:

> So previously the SymbolVendor would only make a strong reference to the object file if it didn't match the object file of the module. Now it always makes one. Might be ok since the Module owns the SymbolVendor and thus owns the SymbolFile. We should make sure we don't end up keeping an object file alive when a module goes away due to multiple strong references. I am guessing it will be ok, but good to verify.

I've checked that the ObjectFile goes away when the owning Module is destroyed (e.g., in response to SBDebugger::MemoryPressureDetected), but I don't think this patch actually changes anything in terms of who-owns-who. The SymbolVendor was already storing a pointer to the object file even in case this was the main module object file (it stored the pointer "in case the object file is different", but the actual storing was unconditional).



More information about the lldb-commits mailing list