[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

Mon Jul 29 21:23:21 PDT 2019

asmith added a comment.

I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub.

You can reproduce the build failure from an x64 command prompt with this cmake command line:

  cmake path-to-llvm-project/llvm -Thost=x64 -DLLVM_ENABLE_PROJECTS="clang;lld;lldb" -DCLANG_DEFAULT_LINKER=lld -DLLVM_ENABLE_ASSERTIONS=ON

And building with:

  msbuild ALL_BUILD.vcxproj /m

In this configuration CMAKE_SYSTEM_PROCESSOR is going to report AMD64 and this is going to use the x64 hosted Visual Studio compiler targeting 32 bit Windows. Probably some of these files need to be wrapped in #if defined(_M_X64).

================
Comment at: lldb/trunk/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.h:1
+//===-- ABIWindows_x86_64.h ----------------------------------------*- C++ -*-===//
+//
----------------
Nit; number of dashes '----' is wrong in the headers of the files added

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62213/new/

https://reviews.llvm.org/D62213