[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

JF Bastien via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 29 17:01:14 PDT 2019


jfb added a comment.

In D65249#1603431 <https://reviews.llvm.org/D65249#1603431>, @BillyONeal wrote:

> (In fact I observe many patterns in this review like:
>
> enum { Foo = alignof(void*); }
>  aligned_storage_t<1234, Foo> x;
>
> and then a bunch of casting to treat it as a char buffer; if it was just born as a char buffer you can remove both the casts and the enum hack:
>
> alignas(void*) char x[1234];


Good point. I went ahead and did that. The patch is now quite trivial :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65249/new/

https://reviews.llvm.org/D65249





More information about the lldb-commits mailing list