[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

[Alex Langford via Phabricator via lldb-commits]

xiaobai added inline comments.


================
Comment at: source/API/SBModule.cpp:525
           module_sp->GetTypeSystemForLanguage(eLanguageTypeC);
-      if (type_system) {
-        CompilerType compiler_type = type_system->GetBuiltinTypeByName(name);
+      if (auto err = type_system_or_err.takeError()) {
+        llvm::consumeError(std::move(err));
----------------
JDevlieghere wrote:
> Any reason you do this instead of
> 
> ```if (!type_system_or_err) {
>   llvm::consumeError(type_system_or_err.takeError());
> ...
> ```
No reason in particular. Is there a benefit in doing so or something I'm misunderstanding?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65122/new/

https://reviews.llvm.org/D65122