[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 29 13:03:04 PDT 2019

clayborg added a comment.

In D65386#1604927 <https://reviews.llvm.org/D65386#1604927>, @jingham wrote:

> It worries me a little bit that we are making it harder and harder to figure out "where does the option for "-t" get stored once this CommandObject's options have been parsed.  Can you show the steps I would have to go through to get from "-f" to OptionEnumSettingsSet::Force or whatever.

Yeah, that has been my experience with table gen stuff. Does the table gen stuff generate code that exists in the build folder, like headers and/or C++ code? Navigating using an IDE often fails on these because the build system doesn't know about it directly. Any way to generate code in the source tree from the .inc files that we check in? Then if anyone modifies the .inc file it would regenerate (during the normal build process which could depend on the .inc _and_ on the .h or .cpp file that gets generated) the .h and .cpp file in the source tree and they would show up as modifications.




More information about the lldb-commits mailing list