[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 29 12:10:13 PDT 2019


xiaobai added a comment.

In D65122#1604352 <https://reviews.llvm.org/D65122#1604352>, @labath wrote:

> I have one remark about the consumeError+LLDB_LOG pattern. As for whether this is better than status quo or not, I still don't have an opinion on that. :)


Thanks for pointing out LLDB_LOG_ERROR. I updated this change so people could have a chance to see what the change would look like so they have something concrete to look at instead of just speculating what it could look like.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65122/new/

https://reviews.llvm.org/D65122





More information about the lldb-commits mailing list