[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

Billy Robert O'Neal III via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 26 17:33:09 PDT 2019


BillyONeal added a comment.

(In fact I observe many patterns in this review like:

enum { Foo = alignof(void*); }
aligned_storage_t<1234, Foo> x;

and then a bunch of casting to treat it as a char buffer; if it was just born as a char buffer you can remove both the casts and the enum hack:

alignas(void*) char x[1234];


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65249/new/

https://reviews.llvm.org/D65249





More information about the lldb-commits mailing list